Standard guestbook using Cloud Datastore API rather than Objectify #388

wsh · 2016-10-26T22:12:39Z

No description provided.

Datastore Java API.

lesv

Good start- PTAL

lesv · 2016-10-26T23:37:21Z

appengine/guestbook-cloud-datastore/README.md

+Finally, in a new shell, [set the Datastore Emulator environmental variables](https://cloud.google.com/datastore/docs/tools/datastore-emulator#setting_environment_variables)
+and run
+
+    mvn clean appengine:devserver


Looks like the old plugin, should be mvn clean appengine:run w/ new.

lesv · 2016-10-26T23:38:32Z

appengine/guestbook-cloud-datastore/README.md

+
+Modify `appengine-web.xml` to reflect your app ID and version, then:
+
+    mvn clean appengine:update


mvn clean appengine:run

You meant deploy, but got it.

lesv · 2016-10-26T23:42:21Z

appengine/guestbook-cloud-datastore/src/main/java/com/example/guestbook/Greeting.java

+    return Objects.hash(key, authorEmail, authorId, content, date);
+  }
+}
+//[END all]


It's common to add toString() if you are doing equals & hashCode().

Fair enough, done.

lesv · 2016-10-26T23:44:47Z

appengine/guestbook-cloud-datastore/src/main/java/com/example/guestbook/Guestbook.java

+
+//[START all]
+public class Guestbook {
+  private static final KeyFactory kf = getKeyFactory(Guestbook.class);


keys or keyfactory

lesv · 2016-10-26T23:45:25Z

appengine/guestbook-cloud-datastore/src/main/java/com/example/guestbook/Guestbook.java

+    return resultListBuilder.build();
+  }
+}
+//[END all]


lesv · 2016-10-26T23:46:34Z

appengine/guestbook-cloud-datastore/src/main/webapp/WEB-INF/appengine-web.xml

@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="utf-8"?>
+<appengine-web-app xmlns="http://appengine.google.com/ns/1.0">
+    <application>your-app-id-here</application>


No longer required

lesv · 2016-10-26T23:46:43Z

appengine/guestbook-cloud-datastore/src/main/webapp/WEB-INF/appengine-web.xml

+<?xml version="1.0" encoding="utf-8"?>
+<appengine-web-app xmlns="http://appengine.google.com/ns/1.0">
+    <application>your-app-id-here</application>
+    <version>your-app-version-here</version>


No longer required

lesv · 2016-10-26T23:46:53Z

appengine/guestbook-cloud-datastore/src/main/webapp/WEB-INF/index.yaml

+  ancestor: yes
+  properties:
+  - name: date
+    direction: desc


lesv · 2016-10-26T23:48:02Z

appengine/guestbook-cloud-datastore/src/main/webapp/guestbook.jsp

+<%
+    } else {
+%>
+<p>Messages in Guestbook '${fn:escapeXml(guestbookName)}'.</p>


YEA - I forgot this recently in some stuff -- good to see it here.

😄 It's in the Objectify one! I just copied it.

codecov-io · 2016-10-27T00:33:09Z

Current coverage is 50.00% (diff: 50.00%)

Merging #388 into master will decrease coverage by 1.55%

@@             master       #388   diff @@
==========================================
  Files            81          4     -77   
  Lines          2547         98   -2449   
  Methods           0          0           
  Messages          0          0           
  Branches        183         22    -161   
==========================================
- Hits           1313         49   -1264   
+ Misses         1191         32   -1159   
+ Partials         43         17     -26

Powered by Codecov. Last update 237e3aa...8285cf4

lesv · 2016-10-27T00:47:27Z

appengine/guestbook-cloud-datastore/pom.xml

+        <plugins>
+            <plugin>
+                <groupId>com.google.appengine</groupId>
+                <artifactId>appengine-maven-plugin</artifactId>


Should be:

<plugin> <groupId>com.google.cloud.tools</groupId> <artifactId>appengine-maven-plugin</artifactId> <version>0.1.2</version> <configuration>        <deploy.promote>true</deploy.promote> <deploy.stopPreviousVersion>true</deploy.stopPreviousVersion> </configuration> </plugin>

lesv · 2016-10-27T00:58:01Z

@ludoch @jerjou @tswast @GoogleCloudPlatform/cloud-tools-for-java FYI - Veneer Datastore on GAE Standard

Thank you to @wsh

…e-plugin to v2.4.2 (#5905) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud.tools:appengine-gradle-plugin](https://togithub.com/GoogleCloudPlatform/app-gradle-plugin) | `2.2.0` -> `2.4.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud.tools:appengine-gradle-plugin/2.4.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud.tools:appengine-gradle-plugin/2.4.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud.tools:appengine-gradle-plugin/2.4.2/compatibility-slim/2.2.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud.tools:appengine-gradle-plugin/2.4.2/confidence-slim/2.2.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>GoogleCloudPlatform/app-gradle-plugin</summary> ### [`v2.4.2`](https://togithub.com/GoogleCloudPlatform/app-gradle-plugin/blob/master/CHANGELOG.md#242) ##### Changed - Update to appengine-plugins-core 0.9.5 ([#405](../../pull/405)) ### [`v2.4.1`](https://togithub.com/GoogleCloudPlatform/app-gradle-plugin/blob/master/CHANGELOG.md#241) ##### Fixed - Fixed bug when using `plugins` block in `build.gradle` ([#388](../../pull/388)) ### [`v2.4.0`](https://togithub.com/GoogleCloudPlatform/app-gradle-plugin/blob/master/CHANGELOG.md#240) ##### Added - `appengine.tools.verbosity` option for defining gcloud log verbosity ([#384](../../pull/384)) ### [`v2.3.0`](https://togithub.com/GoogleCloudPlatform/app-gradle-plugin/blob/master/CHANGELOG.md#230) ##### Changed - Update to appengine-plugins-core 0.9.0 ([#377](../../pull/377)) - Includes support for binary artifacts for app.yaml based deployments ([appengine-plugins-core:#840](https://togithub.com/GoogleCloudPlatform/appengine-plugins-core/issues/840)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/GoogleCloudPlatform/java-docs-samples).

…3.0 (#388) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | `20.2.0` -> `20.3.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/20.3.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/20.3.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/20.3.0/compatibility-slim/20.2.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/20.3.0/confidence-slim/20.2.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻️ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-servicedirectory).

…tion to v0.122.7-beta (#388)

…2.0 (#388) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | minor | `16.1.0` -> `16.2.0` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-datacatalog).

…388) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | `18.1.0` -> `19.0.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/19.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/19.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/19.0.0/compatibility-slim/18.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/19.0.0/confidence-slim/18.1.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-recaptchaenterprise).

…1.0 (#388) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | `19.0.0` -> `19.1.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/19.1.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/19.1.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/19.1.0/compatibility-slim/19.0.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/19.1.0/confidence-slim/19.0.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-document-ai).

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 26, 2016

wsh force-pushed the wsh/standard-guestbook-sans-objectify branch from 48473a5 to 5328ac0 Compare October 26, 2016 22:19

Add a Guestbook example for the standard environment that uses the Cloud

367e7bd

Datastore Java API.

wsh force-pushed the wsh/standard-guestbook-sans-objectify branch from c6c7539 to 367e7bd Compare October 26, 2016 22:53

lesv suggested changes Oct 26, 2016

View reviewed changes

Style fixes and corrections.

02a8173

lesv suggested changes Oct 27, 2016

View reviewed changes

wsh force-pushed the wsh/standard-guestbook-sans-objectify branch 2 times, most recently from b4b680b to 476642f Compare October 27, 2016 00:52

lesv approved these changes Oct 27, 2016

View reviewed changes

Remove extraneous (old Maven plugin) parameters.

3778448

wsh force-pushed the wsh/standard-guestbook-sans-objectify branch from 476642f to 3778448 Compare October 27, 2016 01:00

lesv approved these changes Oct 27, 2016

View reviewed changes

wsh merged commit 1426af0 into master Oct 27, 2016

wsh deleted the wsh/standard-guestbook-sans-objectify branch October 27, 2016 01:07

This was referenced Nov 9, 2022

(WIP) samples: migrate code from googleapis/java-servicedirectory #7396

Closed

[WIP] samples: migrate code from googleapis/java-servicedirectory #7397

Closed

Shabirmean mentioned this pull request Nov 9, 2022

[WIP] samples: migrate code from googleapis/java-servicedirectory #7398

Closed

9 tasks

Shabirmean mentioned this pull request Nov 9, 2022

samples: migrate code from googleapis/java-servicedirectory #7399

Merged

9 tasks

bourgeoisor mentioned this pull request Nov 11, 2022

migrate code from googleapis/java-notification #7406

Closed

9 tasks

bourgeoisor pushed a commit that referenced this pull request Nov 11, 2022

chore(deps): update dependency com.google.cloud:google-cloud-notifica…

f0e62fe

…tion to v0.122.7-beta (#388)

charlieyu1996 mentioned this pull request Nov 11, 2022

migrate code from googleapis/java-datacatalog #7412

Merged

9 tasks

Sita04 mentioned this pull request Nov 11, 2022

migrate code from googleapis/java-recaptchaenterprise #7417

Merged

9 tasks

Shabirmean mentioned this pull request Nov 15, 2022

samples: migrate code from googleapis/java-document-ai #7427

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Standard guestbook using Cloud Datastore API rather than Objectify #388

Standard guestbook using Cloud Datastore API rather than Objectify #388

wsh commented Oct 26, 2016

lesv left a comment

lesv Oct 26, 2016

wsh Oct 27, 2016

lesv Oct 26, 2016

wsh Oct 27, 2016

lesv Oct 26, 2016

lesv Oct 26, 2016

wsh Oct 27, 2016

lesv Oct 26, 2016

wsh Oct 27, 2016

lesv Oct 26, 2016

wsh Oct 27, 2016

lesv Oct 26, 2016

wsh Oct 27, 2016

lesv Oct 26, 2016

wsh Oct 27, 2016

lesv Oct 26, 2016

wsh Oct 27, 2016

lesv Oct 26, 2016

wsh Oct 27, 2016

codecov-io commented Oct 27, 2016 •

edited

Loading

lesv Oct 27, 2016

lesv commented Oct 27, 2016


		Modify `appengine-web.xml` to reflect your app ID and version, then:

		mvn clean appengine:update

Standard guestbook using Cloud Datastore API rather than Objectify #388

Standard guestbook using Cloud Datastore API rather than Objectify #388

Conversation

wsh commented Oct 26, 2016

lesv left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Oct 27, 2016 • edited Loading

Current coverage is 50.00% (diff: 50.00%)

Choose a reason for hiding this comment

lesv commented Oct 27, 2016

codecov-io commented Oct 27, 2016 •

edited

Loading